Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting wayland environment variables at startup #1045

Merged
merged 3 commits into from
Nov 19, 2022
Merged

Conversation

Narice
Copy link
Contributor

@Narice Narice commented Nov 18, 2022

Describe your PR, what does it fix/add?

Answers different issues brought up in #850

  • sets XDG_BACKEND and _JAVA_AWT_WM_NONREPARENTING to wayland and 1 at startup, so that the user doesn't have to worry setting these up.
  • removed these variables from nix modules recommended environment
  • removed XCURSOR_SIZE from nix modules as it is already set

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

NIXOS_OZONE_WL for now stays in the nix modules as it would clutter non-nixos users environment variables and doesn't seem to interact badly with x11 sessions, though it it possible that it could.

Is it ready for merging, or does it need work?

it is fully ready to be merged

@fufexan

setting XDG_BACKEND and _JAVA_AWT_WM_NONREPARENTING in main.cpp
removed these variables from nix modules recommended environemnt
removed XCURSOR_SIZE from nix modules as it is already set
@vaxerski
Copy link
Member

edqhijnoijfweeoi jwef werfoh jnf werikjnlkfwer erf kljnrt ekljnberfg erfg lkb jnerg lkjnb rg e?

src/main.cpp Outdated Show resolved Hide resolved
@Narice
Copy link
Contributor Author

Narice commented Nov 18, 2022

forgot to ping @viperML.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the code side. @fufexan for Nix.

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaxerski vaxerski merged commit c03e4c3 into hyprwm:main Nov 19, 2022
@Narice
Copy link
Contributor Author

Narice commented Nov 20, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants