Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified border #1060

Merged
merged 3 commits into from
Nov 20, 2022
Merged

Unified border #1060

merged 3 commits into from
Nov 20, 2022

Conversation

julianschuler
Copy link
Contributor

Describe your PR, what does it fix/add?

Using negative values for the "gaps_in" parameter already allows the user to create a unified border.
Here is an example config snippet for this case:

general {
    gaps_in = -1
    gaps_out = 0
    border_size = 2
}

Currently, the windows may be drawn in such an order that the border of the active window may not be displayed correctly.

This pull request ensures the active window is drawn last within the first rendering pass.

Here is an example illustrating the current and new behavior with "#" denoting the border of the active window:

Current behavior:      New behavior:
#########+--------+    ##########--------+
#        |        |    #        #        |
#        |        |    #        #        |
#########+--------+    ##########--------+

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Nothing here.

Is it ready for merging, or does it need work?

It is ready for merging.

@vaxerski vaxerski merged commit 41a8975 into hyprwm:main Nov 20, 2022
@julianschuler julianschuler deleted the unified-border branch November 20, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants