Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix unintentional cycling workspace with workspace_swipe #1067

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Bugfix unintentional cycling workspace with workspace_swipe #1067

merged 1 commit into from
Nov 21, 2022

Conversation

CactiChameleon9
Copy link
Contributor

Describe your PR, what does it fix/add?

This PR solves the issue #1053 by adding a new option workspace_swipe_left_cycle to gestures.
If the option is enabled, it is possible to swipe left on the 1st workspace to go the the -1 workspace (old behaviour)
If the option is disabled, it is not possible to go to the other end of the workspaces by swiping (matching the auto new workspace behaviour)

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

workspace_swipe_left_cycle is disabled by default (changing the default behaviour) but can be enabled if the user wishes

Is it ready for merging, or does it need work?

Yes, I would consider this ready for merging.

@vaxerski
Copy link
Member

If you disable creating new with swipe right, iirc it will also cycle when you swipe right on the last workspace. I think unifying that to workspace_swipe_cycles would be a better idea.

@CactiChameleon9
Copy link
Contributor Author

CactiChameleon9 commented Nov 21, 2022

Hmmm... OK that is a little odd.

Default behaviour, create_new = 0:

  • Cannot swipe left or right past the final workspace

Default behaviour, create_new = 1:

  • Can swipe left past the final workspace, but cannot swipe right past the final workspace

Is this a bugfix then as opposed to a feature??
What should I implement? I can completely redo what I have done in order to enable swipe-around.... (doesn't work for create_new = 0 currently with or without my work). Or I could remove the setting and change this into a consistency bugfix

@vaxerski
Copy link
Member

Oh, wait, it doesn't wrap. Right. Yeah this is a bugfix then. (Sorry I am a bit retarded) Make it mandatory for now (not configurable)

@CactiChameleon9
Copy link
Contributor Author

Cool. Thats easier for me. No worries btw :)

@CactiChameleon9 CactiChameleon9 changed the title Add swipe left cycle option Bugfix unintentional cycling workspace with workspace_swipe Nov 21, 2022
@CactiChameleon9
Copy link
Contributor Author

Should be done. Feel free to test more, but seems fine to me 👍

@vaxerski vaxerski merged commit f00b2fd into hyprwm:main Nov 21, 2022
@vaxerski
Copy link
Member

Thanks!

scorpion-26 pushed a commit to scorpion-26/Hyprland that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants