nix: add cmake to devshell and create a "wlroots-ready" devshell #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useful to not build wlroots and in nixos
FlafyDev
force-pushed
the
fix-devshell
branch
from
6a9c1d7
to
5a84bdb
Compare
|
Why do this instead of building with meson? |
Ah I was not aware building with meson was an option. But I still think the devshell should allow support for compiling with cmake. The wiki says it's the recommended way and it documents more for cmake than meson(like https://wiki.hyprland.org/Contributing-and-Debugging ) |
|
Alright. I think the default shell should have wlroots in it already, so no need for another one. |
done |
fufexan
pushed a commit
that referenced
this pull request
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
fixes
sh: line 1: cmake: command not foundwhen runningmake debugby addingcmakeas a nativeBuildInput.adds a
wlroots-readydevshell which puts wlroots in the devshell so nix compiles it.Especially useful for NixOS since
make configcan't installwlroots: (no/usr/include)Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
none
Is it ready for merging, or does it need work?
ready for review/merge.