-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use internal device naming for Hyprctl devices #1174
Conversation
* Use internal naming for Hyprctl devices * Use c-strings rather than std::string
I have the impression that this commit introduces a problem for the per device input config . |
why?
|
Because the wiki says "The name can be easily obtained by doing hyprctl devices." and as far as I can remember this is how I got |
it is taken into account and that's what the name was internally converted to anyways. |
Ok, great, thank you very much for these clarifications and for all the work done on Hyprland. |
I don't understand why but the following works
but using the name given by
EDIT: my bad, both works but as my name was logitech-mx-master it's now logitech-mx-master-1 |
:P |
Describe your PR, what does it fix/add?
Due to 409ac12 commit, Hyprland internally uses a bit different name from the WLR device one. However, that was not reflected in
hyprctl devices
, this commit fixes the issue.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No, expect that switches are still using the WLR device name.
Is it ready for merging, or does it need work?
Yes.