Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal device naming for Hyprctl devices #1174

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Conversation

leftas
Copy link
Contributor

@leftas leftas commented Dec 4, 2022

Describe your PR, what does it fix/add?

Due to 409ac12 commit, Hyprland internally uses a bit different name from the WLR device one. However, that was not reflected in hyprctl devices, this commit fixes the issue.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

No, expect that switches are still using the WLR device name.

Is it ready for merging, or does it need work?

Yes.

src/debug/HyprCtl.cpp Outdated Show resolved Hide resolved
@vaxerski vaxerski merged commit d9998f2 into hyprwm:main Dec 4, 2022
fufexan pushed a commit that referenced this pull request Dec 5, 2022
* Use internal naming for Hyprctl devices

* Use c-strings rather than std::string
@jlaunay
Copy link

jlaunay commented Dec 8, 2022

I have the impression that this commit introduces a problem for the per device input config .
I have for example sensitivity = -0.5 for device Logitech MX Master but hyprctl devices return logitech-mx-master that I can't use in hyprland.conf.

@vaxerski
Copy link
Member

vaxerski commented Dec 8, 2022

why?

device:logitech-mx-master {
    sensitivity = -0.5
}

@jlaunay
Copy link

jlaunay commented Dec 8, 2022

Because the wiki says "The name can be easily obtained by doing hyprctl devices." and as far as I can remember this is how I got Logitech MX Master before.
I will try to use logitech-mx-master instead of Logitech MX Master but when I tested it I had the impression that it was not taken into account and I did not know what to use.

@vaxerski
Copy link
Member

vaxerski commented Dec 8, 2022

it is taken into account and that's what the name was internally converted to anyways.

@jlaunay
Copy link

jlaunay commented Dec 8, 2022

Ok, great, thank you very much for these clarifications and for all the work done on Hyprland.

@jlaunay
Copy link

jlaunay commented Dec 11, 2022

I don't understand why but the following works

device:Logitech MX Master {
    enabled = false
}

but using the name given by hyprctl devices have no effect

device:logitech-mx-master {
    enabled = false
}

EDIT: my bad, both works but as my name was logitech-mx-master it's now logitech-mx-master-1

@vaxerski
Copy link
Member

:P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants