swallow: Add swallow_exception_regex #2026
Conversation
Currently, if a window class is specified in the swallow_regex (e.g. Kitty) it will swallow every other window spawned by it automatically. Many other WMs implementing this functionality allow for defining exceptions from this rule. For instance, we want Kitty to swallow sxiv or zathura but we do not want Kitty to swallow something like wev. This commit adds an additional regex - swallow_exception_regex where these exceptions can be defined. This regex is then compared against the title of the window about to be swallowed and if it happens to be a match, aborts the swallowing. This works because whenever an application that could be swallowed is launched by a terminal, the class of the terminal remains the same while the title changes to whatever the application's name is, thus letting it be matched against a regex.
|
overall ok, make a wiki mr plox |
Wiki PR submitted, it's mentioned above |
|
discrepancy: in the wiki you say regex for the child, while here you match against the parent? |
|
Hm I think it probably makes more sense for it to be described this way in the wiki context? As in we have a parent (Kitty) that spawns a child process (wev). At that point the title of that Kitty instance changes to 'wev' which is why that's what we match against. I think emphasising 'child' on the wiki makes it easier for people tell which names go into which regex but if you have a better way to phrase this that's fine by me. |
|
you can add that note, but since you match the parent, you should state you match the parent. Shells/terms might have different methods of handling shit |
|
Fair enough, I updated the PR, how about this? |
|
yeah lgtm |
Describe your PR, what does it fix/add?
Currently, if a window class is specified in the swallow_regex (e.g. Kitty) it will swallow every other window spawned by it automatically. Many other WMs implementing this functionality allow for defining exceptions from this rule. For instance, we want Kitty to swallow sxiv or zathura but we do not want Kitty to swallow something like wev.
This commit adds an additional regex - swallow_exception_regex where these exceptions can be defined. This regex is then compared against the title of the window about to be swallowed and if it happens to be a match, aborts the swallowing.
This works because whenever an application that could be swallowed is launched by a terminal, the class of the terminal remains the same while the title changes to whatever the application's name is, thus letting it be matched against a regex.
Is it ready for merging, or does it need work?
The PR should be ready to be merged unless the config option name should be changed for some reason. Presumably the documentation will need to be updated as well.
Solves issue #2002