Add split preselection #2240
Merged
Add split preselection #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
requested changes
May 4, 2023
vaxerski
reviewed
May 5, 2023
DashieTM
changed the title
|
I added a persistent mode as well, changes are in the description above, not much changed, seemed like a good thing to include. Now people can go out and tell others hey hyprland now has "manual tiling" as well :P |
vaxerski
requested changes
May 5, 2023
vaxerski
requested changes
May 5, 2023
|
I have been using this, haven't noticed anything. It essentially just uses what is already there either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This adds the bspwm like preselection in case you want your window to open in a specific direction.
Note this only works for Dwindle.
Changes
added a persistent mode: permanent_direction_override
this leaves the selected direction until: another direction has been specified, no direction has been specified (any other character as direction as those who would specify a direction), or this mode is turned off in config.
config entry is in dwindle -> dwindle:permanent_direction_override
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I am not a user of groups, and or special workspaces, so if there are issues with them please tell me.
Is it ready for merging, or does it need work?
It should be ready for merging, a quick look at the impl is ofc appreciated.
Usage
hyprctl dispatch layoutmsg "preselect u" -> up (or t)
hyprctl dispatch layoutmsg "preselect d" -> down (or b)
hyprctl dispatch layoutmsg "preselect r" -> right
hyprctl dispatch layoutmsg "preselect l" -> left
hyprctl dispatch layoutmsg "preselect n" -> no direction (this can be any character other than those above)
the no direction is needed to reset the override in persistent mode.
wiki entry: hyprwm/hyprland-wiki#218
implements: #836