Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches group toplevel-activated #2931

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Conversation

MightyPlaza
Copy link
Contributor

fixes hidden group windows always having toplevel activated status

not ideal, but doing it the right way seems to require messing with other functions, which will likely break stuff

	modified:   src/Compositor.cpp
	modified:   src/Window.cpp
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant you use the deactivate all func in ccompositor iirc?

	modified:   src/Compositor.cpp
@MightyPlaza
Copy link
Contributor Author

did only find done for workspaces, and don't think that's it
if there is one that does that for all the windows, it's even worse than doing just for the group

@vaxerski
Copy link
Member

fair point

src/Compositor.cpp Outdated Show resolved Hide resolved
	modified:   src/Compositor.cpp
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top g gangsta full

@vaxerski vaxerski merged commit c4c3b59 into hyprwm:main Aug 10, 2023
7 checks passed
@MightyPlaza MightyPlaza deleted the qfix-toplevel branch August 10, 2023 23:16
scorpion-26 pushed a commit to scorpion-26/Hyprland that referenced this pull request Aug 31, 2023
* patches group toplevel-activated

	modified:   src/Compositor.cpp
	modified:   src/Window.cpp

* remove redundant call

	modified:   src/Compositor.cpp

* fix style
	modified:   src/Compositor.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants