Integrate HASCONFIG into CConfigManager::getConfigValueSafeDevice #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdamianik
force-pushed
the
integrate-hasconfig-into-getconfigvaluesafedevice
branch
from
3aa1f25
to
e7d27ed
Compare
pdamianik
force-pushed
the
integrate-hasconfig-into-getconfigvaluesafedevice
branch
from
e7d27ed
to
939949e
Compare
pdamianik
deleted the
integrate-hasconfig-into-getconfigvaluesafedevice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
With the new fallback argument for
CConfigManager::getConfigValueSafeDevice, theHASCONFIGconstant has become unnecessary in most cases. This PR adds the ability to fall back when there is no config for a device toCConfigManager::getConfigValueSafeDeviceand removes most uses ofHASCONFIG.Is it ready for merging, or does it need work?
All ready.