movewindow to screen edge for floating windows #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Sep 10, 2023
thejch
pushed a commit
to thejch/Hyprland
that referenced
this pull request
Sep 13, 2023
* movewindow to screen edge for floating windows * review changes * constify vars --------- Co-authored-by: Leeman <lstrout@enlj.com> Co-authored-by: vaxerski <vaxry@vaxry.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements move to screen edge in the
movewindowdispatcher. If the active window is floating, move it to the designated screen edge.I think this is ready for merge but I'm not sure about the formatting of the switch{} block. Looks bad to me but I am pretty sure your .clang-format is being followed.