add on-screen constraint to wrv2 'move' #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Sep 10, 2023
vaxerski
reviewed
Sep 11, 2023
added 2 commits
September 11, 2023 18:43
thejch
pushed a commit
to thejch/Hyprland
that referenced
this pull request
Sep 13, 2023
* add on-screen constraint to wrv2 'move' * review changes * std::clamp * more parens --------- Co-authored-by: Leeman <lstrout@enlj.com>
|
@vaxerski anything I need to do to get the last check (wlroots buld) to pass so this actually lands? |
|
this is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an
onscreendirective to windowsrulev2movethat causes the window to be fully on the screen (if it is not too large).My usage for this is:
windowrulev2 = move onscreen cursor -50% -50%,floating:1,class:^(xfce4-terminal|kitty)$This will place my terminals centered under the mouse unless it's toward the edge of the screen where they will be nudged to remain fully within the screen.
For too-large windows, the bottom right corner is forced onto the screen. It could be top left with additional code.
Ready for merge.