Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create group and groupbar config sections #3522

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

MightyPlaza
Copy link
Contributor

@MightyPlaza MightyPlaza commented Oct 8, 2023

Moves group related variables to group and group:groupbar sections

haven't messed with nogroup related options but they probably should be moved in to here as well
(gradient hot reloading still doesn't work, but that is for another PR)

begins splitting commits from #3197

didn't find any missing instances with grep -nr and all changed options seem to work, so should cause any issues

wiki: hyprwm/hyprland-wiki#366

modified:   src/Compositor.cpp
modified:   src/config/ConfigManager.cpp
modified:   src/layout/DwindleLayout.cpp
modified:   src/layout/MasterLayout.cpp
modified:   src/managers/KeybindManager.cpp
modified:   src/managers/input/InputManager.cpp
modified:   src/render/decorations/CHyprGroupBarDecoration.cpp
modified:   src/Compositor.cpp
modified:   src/config/ConfigManager.cpp
modified:   src/render/decorations/CHyprGroupBarDecoration.cpp
modified:   config/ConfigManager.cpp
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaxerski vaxerski merged commit d537815 into hyprwm:main Oct 10, 2023
11 checks passed
@MightyPlaza MightyPlaza deleted the group-config branch October 10, 2023 20:06
Airradda added a commit to Airradda/stylix that referenced this pull request Oct 11, 2023
This resolve the issues introduce in Hyprland PR [#3522](hyprwm/Hyprland#3522) which moved group variables out of general and into their own section.
Airradda added a commit to Airradda/stylix that referenced this pull request Oct 11, 2023
This resolve the issues introduce in Hyprland PR [#3522](hyprwm/Hyprland#3522) which moved group variables out of general and into their own section.
danth pushed a commit to danth/stylix that referenced this pull request Oct 28, 2023
This resolve the issues introduced in hyprwm/Hyprland#3522, which
moved group variables out of general and into their own section.
willemml pushed a commit to willemml/stylix that referenced this pull request Nov 24, 2023
This resolve the issues introduced in hyprwm/Hyprland#3522, which
moved group variables out of general and into their own section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants