Add option to center the cursor on the focused window when switching workspaces #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdamianik
force-pushed
the
center_on_workspace
branch
from
b81d0fb
to
120669b
Compare
|
Tested |
pdamianik
force-pushed
the
center_on_workspace
branch
2 times, most recently
from
79e30aa
to
8dae9ff
Compare
|
Wiki pr: hyprwm/hyprland-wiki#368 |
pdamianik
changed the title
pdamianik
changed the title
|
shouldn't that go into binds:? |
pdamianik
force-pushed
the
center_on_workspace
branch
from
8e32ce0
to
fdaaef6
Compare
pdamianik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Adds an option to disable centering the cursor on a workspace and instead center on the last active window when switching between workspaces with the
workspacedispatcher (non breaking - default value is current behavior). See #3491.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I also switched the calculation for the window center in
swapActive()to use themiddle()method, as it seems like using the current position (I assume this includes animations) is a mistake.Is it ready for merging, or does it need work?
Ready. I have no particular interest in having this merged, I just provide the code. For any questions regarding the feature please ask the author of issue #3491.