Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderer: unbreak on 32-bit archs via static_cast #3589

Merged
merged 1 commit into from
Oct 17, 2023
Merged

renderer: unbreak on 32-bit archs via static_cast #3589

merged 1 commit into from
Oct 17, 2023

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Oct 16, 2023 •
edited

Regressed by #3459
intValue returns int64_t often defined via long long but L literal suffix is long

@jbeich
renderer: cast std::clamp args to be of the same type
913c8b8 
src/render/OpenGL.cpp:1769:41: error: no matching function for call to 'clamp'
    const auto         FORCEWALLPAPER = std::clamp(*PFORCEWALLPAPER, -1L, 2L);
                                        ^~~~~~~~~~
/usr/include/c++/v1/__algorithm/clamp.h:38:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('int64_t' (aka 'long long') vs. 'long')
clamp(const _Tp& __v, const _Tp& __lo, const _Tp& __hi)
^
/usr/include/c++/v1/__algorithm/clamp.h:27:1: note: candidate function template not viable: requires 4 arguments, but 3 were provided
clamp(const _Tp& __v, const _Tp& __lo, const _Tp& __hi, _Compare __comp)
^
vaxerski
vaxerski approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok but who the fuck is running a 32-bit arch

@vaxerski vaxerski merged commit 93676f9 into hyprwm:main Oct 17, 2023
11 checks passed
@jbeich jbeich deleted the 32-bit branch October 18, 2023 15:09
@jbeich jbeich mentioned this pull request Dec 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbeich @vaxerski