Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more changes in rgb2hsl. #3834

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Some more changes in rgb2hsl. #3834

merged 2 commits into from
Nov 12, 2023

Conversation

Dickby
Copy link
Contributor

@Dickby Dickby commented Nov 11, 2023

Describe your PR, what does it fix/add?

  1. also calculate marks and adds only if they are used.
  2. use glsl vector functions to build the masks vector and avoid multiple branches.
  3. change the adds initialization to divide the Vector by delta at once
  4. add missing new line between functions

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Is it ready for merging, or does it need work?

I think it's ready.

@Eclextic
Copy link

Eclextic commented Nov 11, 2023

What the f is the difference between equal and ==?
Doesn't the compiler transform them anyways?

Rest looks good!

@Dickby
Copy link
Contributor Author

Dickby commented Nov 11, 2023

@Eclextic
equal works on vectors e.g
equal(vec3(1.0,2.0,3.0), vec3(2.0,2.0,2.0)) produces a bool vector (0 , 1 , 0)

@Eclextic
Copy link

ooooh! I didn't know that!
So we can get a bool for every element in the vector separately!
Thanks for that info, that's awesome!

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coolio

@vaxerski vaxerski merged commit e974d1f into hyprwm:main Nov 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants