-
-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workspace rule for master layout orientation #3964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd do a similiar approach to dispatchers. layoutopt
or something and then orientation top
etc
Changed it to |
for future-proofing the code it'd be better if it was a map str -> str, we might add more layoutopts later. |
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, wiki mr needed though
Actually, str -> str is not the best idea since you can't store other types (bool, int, whatever may come in the future). I want to use str -> |
Made some changes. Wiki MR added as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Describe your PR, what does it fix/add?
Addresses #3174
No monitor rules but we can at least have a workspace rule
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Not sure if this is ideal because this is only for master but it's in the general workspace rules.
Is it ready for merging, or does it need work?
Ready.