Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace rule for master layout orientation #3964

Merged
merged 5 commits into from
Dec 2, 2023

Conversation

thejch
Copy link
Contributor

@thejch thejch commented Nov 26, 2023

Describe your PR, what does it fix/add?

Addresses #3174
No monitor rules but we can at least have a workspace rule

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Not sure if this is ideal because this is only for master but it's in the general workspace rules.

Is it ready for merging, or does it need work?

Ready.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd do a similiar approach to dispatchers. layoutopt or something and then orientation top etc

@thejch
Copy link
Contributor Author

thejch commented Nov 27, 2023

I'd do a similiar approach to dispatchers. layoutopt or something and then orientation top etc

Changed it to layoutopt:orientation:top

@vaxerski
Copy link
Member

for future-proofing the code it'd be better if it was a map str -> str, we might add more layoutopts later.

@thejch
Copy link
Contributor Author

thejch commented Nov 28, 2023

for future-proofing the code it'd be better if it was a map str -> str, we might add more layoutopts later.

added

vaxerski
vaxerski previously approved these changes Nov 28, 2023
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, wiki mr needed though

@thejch
Copy link
Contributor Author

thejch commented Nov 28, 2023

Actually, str -> str is not the best idea since you can't store other types (bool, int, whatever may come in the future). I want to use str -> std::any for this, or even a struct, but I think std::any sounds easier to deal with atm. Thoughts?

@thejch
Copy link
Contributor Author

thejch commented Dec 2, 2023

Made some changes. Wiki MR added as well

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaxerski vaxerski merged commit 758cf90 into hyprwm:main Dec 2, 2023
10 checks passed
@thejch thejch deleted the workspace-orientation branch March 3, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants