master layout: change the mfact dispatcher to use splitratio #4766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Change the mfact dispatcher to use split ratio, allowing increment/decrement.
I realized this dispatcher does the same thing as
splitratio
, so I'm just changing it to call the latter, this allows you to increment/decrement the mfact in addition to only being able to set the exact mfact.I also thought about just removing it since splitratio exists, but the splitratio dispatcher is really confusing, as it does two different and not necessarily related things in dwindle and master. You also wont find it in the master layout wiki when you look for it since it's not a layout specific dispatcher, but it kinda should be imo. The mfact is a very layout-specific config that is specific to master, and you usually won't look in the universal dispatchers for such a thing, and it's not clear that splitratio changes the mfact in master. I think it would make more sense in the future to have two different dispatchers separately in dwindle and master that will do what this
splitratio
dispatcher does. Having a dispatcher for the mfact itself seems much more easier to understand.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Needs wiki mr
Is it ready for merging, or does it need work?