Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master layout: change the mfact dispatcher to use splitratio #4766

Merged
merged 2 commits into from Apr 13, 2024

Conversation

thejch
Copy link
Contributor

@thejch thejch commented Feb 20, 2024

Describe your PR, what does it fix/add?

Change the mfact dispatcher to use split ratio, allowing increment/decrement.
I realized this dispatcher does the same thing as splitratio, so I'm just changing it to call the latter, this allows you to increment/decrement the mfact in addition to only being able to set the exact mfact.

I also thought about just removing it since splitratio exists, but the splitratio dispatcher is really confusing, as it does two different and not necessarily related things in dwindle and master. You also wont find it in the master layout wiki when you look for it since it's not a layout specific dispatcher, but it kinda should be imo. The mfact is a very layout-specific config that is specific to master, and you usually won't look in the universal dispatchers for such a thing, and it's not clear that splitratio changes the mfact in master. I think it would make more sense in the future to have two different dispatchers separately in dwindle and master that will do what this splitratio dispatcher does. Having a dispatcher for the mfact itself seems much more easier to understand.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Needs wiki mr

Is it ready for merging, or does it need work?

@janpeterd
Copy link
Contributor

janpeterd commented Apr 12, 2024

I added a wiki mr
hyprwm/hyprland-wiki#595

@vaxerski vaxerski merged commit 34396f5 into hyprwm:main Apr 13, 2024
11 checks passed
@thejch thejch deleted the mfact-dispatcher branch April 13, 2024 08:31
lisuke pushed a commit to lisuke/Hyprland that referenced this pull request Apr 15, 2024
* master layout: change the mfact dispatcher to use splitratio

* add space for concat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants