monitor: remove commas from short description #4970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `hyprctl monitor` shows szShortDescription now, it needs to be sanitized. (See hyprwm#2457) Also, monitor selectors are now compared against szShortDescription and szDescription to avoid re-striping the string.
MikeWalrus
added a commit
to MikeWalrus/nwg-displays
that referenced
this pull request
Mar 5, 2024
Hyprland strips commas from their monitor descriptions. Therefore, we should use the sanitized descriptions directly instead of building the string from scratch. Note that descriptions with commas won't work before hyprwm/Hyprland#4970 is merged.
lisuke
pushed a commit
to lisuke/Hyprland
that referenced
this pull request
Apr 15, 2024
Since `hyprctl monitor` shows szShortDescription now, it needs to be sanitized. (See hyprwm#2457) Also, monitor selectors are now compared against szShortDescription and szDescription to avoid re-striping the string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
hyprctl monitorshows szShortDescription now, it needs to be sanitized. (See #2457)Also, monitor selectors are now compared against szShortDescription and szDescription to avoid re-striping the string.