Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix master layout window focus and scroll #5074

Merged
merged 5 commits into from Mar 13, 2024
Merged

Fix master layout window focus and scroll #5074

merged 5 commits into from Mar 13, 2024

Conversation

thejch
Copy link
Contributor

@thejch thejch commented Mar 12, 2024

Describe your PR, what does it fix/add?

Fixes #4127
Fixes #5006
Removed some duplicate code

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

This shouldn't change any bahavior other than fixing the issue.
In the future it's probably better to make switchToWindow use common code with CKeybindManager::switchToWindow

Is it ready for merging, or does it need work?

Ready

vaxerski
vaxerski previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I'd also like someone to test this from the affected issues

src/Compositor.cpp Outdated Show resolved Hide resolved
This was referenced Mar 12, 2024
Closed
Closed
vaxerski
vaxerski approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@vaxerski vaxerski merged commit 7ea555d into hyprwm:main Mar 13, 2024
10 of 11 checks passed
@thejch
Copy link
Contributor Author

thejch commented Mar 13, 2024

Took a look at the issues, I realize there's still
#3737
#3679
#2628
tbh it's probably better to just put the simulate mouse in compositor::focusWindow to always call it anyway, which would just fix all these issues, and many more, and prevent potential ones to come
But theres quite a few calls to that method and you'd have to double check every place it's called to make sure nothing is broken

@thejch thejch deleted the master-scroll branch March 13, 2024 06:07
lisuke pushed a commit to lisuke/Hyprland that referenced this pull request Apr 15, 2024
@thejch @lisuke
master: Fix master layout window focus and scroll (hyprwm#5074)
a962a35 
* fix master switch window scrolling

* fix some more dispatchers and remove some duplicate code

* refactor and remove duplicate code

* fix focusmonitor: hyprwm#5006 (comment)

* change check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@thejch @vaxerski