Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace/core: Refactor workspace storage #5380

Merged
merged 2 commits into from Apr 2, 2024
Merged

Conversation

vaxerski
Copy link
Member

@vaxerski vaxerski commented Apr 2, 2024

1/3 (next: CMonitor, CWindow)

Rewrites how workspaces are stored. They are now shared pointers, passed around.

cc @outfoxxed (hy3) @fufexan (review)

todo:

  • wiki

breaking:

  • all internal events with CWorkspace* now pass PHLWORKSPACE, plus vectors where applicable are void* -> std::any

@ErrorNoInternet
Copy link
Contributor

ErrorNoInternet commented Apr 2, 2024

movefocusing to an empty workspace on another monitor consistently crashes (i think thats af3a61a)

hyprlandCrashReport2312999.txt

edit: i think it crashes while doing a bunch of other stuff too, had like 6 crashes in 2 hours from the assertion

crashes.tar.gz

@sungyoonc
Copy link
Contributor

Noticing a lot of crash too. Moving a window, opening a new window(e.g. file dialog)

hyprlandCrashReport31198.txt
hyprlandCrashReport32768.txt

@vaxerski
Copy link
Member Author

vaxerski commented Apr 2, 2024

lol, all the same

@vaxerski
Copy link
Member Author

vaxerski commented Apr 2, 2024

fixed in main and rebased.

@ErrorNoInternet
Copy link
Contributor

works for me after a few hours of testing

@vaxerski
Copy link
Member Author

vaxerski commented Apr 2, 2024

cool merging thanks

@vaxerski vaxerski merged commit ef23ef6 into main Apr 2, 2024
17 checks passed
lisuke pushed a commit to lisuke/Hyprland that referenced this pull request Apr 15, 2024
* refactor workspaces to use ptrs

* clang-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants