Allow setting per-window fullscreen opacity #5470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
previously approved these changes
Apr 7, 2024
|
conflicts :/ |
SoSeDiK
force-pushed
the
fullscreen-alpha
branch
from
4d43ed7
to
cca3ebc
Compare
|
Rebased |
vaxerski
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Currently, Hyprland has three global window opacity rules: active, inactive, fullscreen.
The first two can be set on a per-window basis. This PR adds the ability to set individual window opacity for fullscreen as well.
Resolves #2663.
Window rule now allows specifying third parameter for fullscreen:
Or with hyprctl:
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Specifying a singular value for window rule is applying it for both active and inactive window states. With this change, it'll also apply for fullscreen state. That's completely fine by me, but I'm not sure if that's wanted/expected behavior, or if fullscreen should instead fallback to the global value unless specified explicitly.
hyprctl completions were generated by
complgencommand insidehyprctl.usage.Is it ready for merging, or does it need work?
Should be ready. Will make a PR to wiki as well if everything's fine.