fix: manage active keyboard for seat after destroying one #5725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
approved these changes
Apr 23, 2024
gulafaran
pushed a commit
to gulafaran/Hyprland
that referenced
this pull request
Apr 26, 2024
* fix: manage active keyboard for seat after destroying one * chore: clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
There is a bug in the management of keyboard focus when you have more than one keyboard connected (like a laptop with external KVM switch scenario) and then you disconnect one.
To reproduce:
Then you will see that what you are typing will be listen by the old window 0 instead of the focused window 1
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No
Is it ready for merging, or does it need work?
Check if the check for
pKeyboard->activeis really needed to change them_pActiveKeyboardafter destroying the keyboard