Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some colors to stdout log 馃敶馃煛馃煝馃數馃煟 #5778

Merged
merged 3 commits into from Apr 29, 2024

Conversation

thejch
Copy link
Contributor

@thejch thejch commented Apr 27, 2024

Describe your PR, what does it fix/add?

Add some colors to stdout log 馃敶馃煛馃煝馃數馃煟
馃敶 error
馃煛 warning
馃煝 info
馃數 trace
馃煟 critical

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

not really

Is it ready for merging, or does it need work?

should be ready

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be disableable

@thejch
Copy link
Contributor Author

thejch commented Apr 27, 2024

this should be disableable

added

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks. Wiki mr needed.

@vaxerski vaxerski merged commit a783cd8 into hyprwm:main Apr 29, 2024
10 checks passed
@thejch thejch deleted the color-log branch April 29, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants