fix xwayland config option for nix #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building Hyprland in nix using the following home-manager recipe:
```nix
wayland.windowManager.hyprland = {
enable = true;
xwayland = false;
};
```
The default nix configuration still makes reference to a compile argument `NO_XWAYLAND`, but the `meson_options.txt` only makes reference to `xwayland`. This causes the build to fail with:
```
meson.build:1:0: ERROR: Unknown options: "NO_XWAYLAND"
```
This change fixes that issue. This still doesn't allow you to build Hyprland without having XWayland installed (hyprwm#178), but it should at least allow for valid nix configurations for when that issue gets resolved.
viperML
approved these changes
Aug 27, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
When building Hyprland in nix using the following home-manager recipe:
The default nix configuration still makes reference to a compile argument
NO_XWAYLAND, but themeson_options.txtonly makes reference toxwayland. This causes the build to fail with:This change fixes that issue.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This still doesn't allow you to build Hyprland without having XWayland installed (#178), but it should at least allow for valid nix configurations for when that issue gets resolved.
Is it ready for merging, or does it need work?
The change does not touch any of the actual code, but it might require the root
flake.nix/flake.lockto be updated to bump the patch version.