Fix cursor warping unnecessarily

[Agent00Ming]

modified:   src/protocols/PointerConstraints.cpp

Describe your PR, what does it fix/add?

Fixes #5881 and fixes #5774

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Can't reproduce any of the other issues mentioned in #5774 with or without the change made in 2e76376 so it might reintroduce those issues. None from my testing in Minecraft (xwayland and pseudo-wayland with system GLFW), Blender and some other steam games.

Is it ready for merging, or does it need work?

Ready.

[vaxerski]

I'll wait for the reporters

[bubba-champion]

With this change, I can no longer reproduce the problem described in #5774.

[vaxerski]

doesn't make sense though... if it's not locked, it means it's confined. So... warp when it's confined? That's what we are trying to battle though?

Maybe the flag is set wrong?

[Agent00Ming]

The warp in activate() might be redundant (?).
logging patch

This behaviour is rather strange actually:
(deactivate() is called only when focus is changed via keybind)

Minecraft (wayland compatible GLFW)

[[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Deactivate: locked=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Deactivate: locked=true
[LOG] [PointerConstraints] Activate: locked=true

locked is only ever true and it seems that something else is warping the pointer to the center when opening the pause menu/inventory.

Minecraft (XWayland)

[LOG] [PointerConstraints] Activate: locked!=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Activate: locked!=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Deactivate: locked=true
[LOG] [PointerConstraints] Activate: locked!=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Deactivate: locked=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Deactivate: locked=true
[LOG] [PointerConstraints] Activate: locked=true

locked is false when closing any menu and is immediately true right after. Two activate() calls happen each time you close a menu but not when focus is regained on mouseover.

The only time I got locked to not be true was with Minecraft on XWayland. No other mouse grab interactions I've tested did that.

.NET XWayland program that grabs mouse

[LOG] [PointerConstraints] Activate: locked!=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Deactivate: locked=true
[LOG] [PointerConstraints] Activate: locked!=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Deactivate: locked=true
[LOG] [PointerConstraints] Activate: locked!=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Deactivate: locked=true
[LOG] [PointerConstraints] Activate: locked!=true
[LOG] [PointerConstraints] Activate: locked=true
[LOG] [PointerConstraints] Deactivate: locked=true
[LOG] [PointerConstraints] Activate: locked!=true
[LOG] [PointerConstraints] Activate: locked=true

[calebaden]

I tested this patch in Blender and StarCitizen and it has fixed the issues from #5881.

[Agent00Ming]

I've looked at the history of the old restraint impl and it seems like these warps are simply a remnant from #4889. The warp in deactivate() doesn't end up ever doing anything from my testing. The warp in activate() only seems to introduce issues and I couldn't find the reason why it was added. Everything seems to work on the surface though.

[vaxerski]

yeah, makes sense.

[vaxerski]

can someone verify the new patch works tho?

[bubba-champion]

With the new patch, the issue is still not reproducible. I can't say anything about the crashes/freezes mentioned in #5774 (comment), since I haven't encountered them.

[vaxerski]

cool, merging then. Thanks!