Cursor/Tablet: move to a hyprland impl #5902
Conversation
vaxerski
force-pushed
the
cursor-rewrite
branch
2 times, most recently
from
30a75af
to
6899b9e
Compare
|
Tablet done. Haven't tested, needs testing. @fufexan pls and ofc anyone else who has one. I don't know what a "strip" and "ring" is, those are left unimplemented because I am unsure how they work and what they do. Also it's 2:16am. If anyone knows, lmk. |
vaxerski
force-pushed
the
cursor-rewrite
branch
2 times, most recently
from
7468a89
to
5a6bee9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
what is and in what way |
This comment was marked as outdated.
This comment was marked as outdated.
|
post crash report when you crash |
|
My bad I forgot I was running plugins, also a |
This comment was marked as outdated.
This comment was marked as outdated.
|
does that mean it works without plugins? (wouldn't be a huge surprise) skip loading plugins as in? Like, reject to load plugins altogether? It is doable, but a config opt would make more sense imo edit: you were faster. Thanks, great news. Also please check if monitor and area mappings in the config work if possible I'll try to finish this during the day (its 4am...) but I can't promise anything as I have an exam on tuesday. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Actually I think I may have misattributed the crash to the plugin perhaps, it's crashing like before with the plugin. I suspect something is causing it to crash most of the time but not always. Anyway, here is the log wasn't able to use transformations but crashed regardless. I guess I just got very lucky or unlucky depending on how you view it |
|
Ags seems to be the culprit in making it crash for some reason, disabling that allows me to start Hyprland consistently but then I get strange errors in Firefox like this. I am 99% sure when I had it working I was using the updated version but I guess something weird could have happened without realizing Edit: pretty certain I accidentally loaded wrong version, must have gotten confused when trying to rebuild older Hyprland so I could at least attempt to post logs or something sorry I'm a moron. Pretty much no apps start except for Kitty when I get past crashing by disabling Ags. The ones that don't complain about not being able to find monitor or something along those lines always seemingly |
|
crash should be fixed. Typical 2am mistake. |
vaxerski
force-pushed
the
cursor-rewrite
branch
3 times, most recently
from
9af47df
to
ed9a189
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
it's cause of this, prolly: #5902 (comment) |
This comment was marked as outdated.
This comment was marked as outdated.
|
yeah I have no fucking clue how that happens, tryna figure out rn. |
|
found it I think, will fix, gimme sec. |
|
okay that should be fixed. Now, why do client-side cursors not render... |
|
There aren't any bugs left that I know of, so send it. The other tablet users will find the undiscovered bugs 😈 |
|
lets fuckin roll |
Of course there will be more bugs, you can’t appease every spacebar heating user, but for now, seems stable enough to throw at the labrats, I used it yesterday for the rest of the day and didn’t have any functionality issues, sounds like we gtg. Obligatory clueless LGTM |
This moves wlr_cursor to a completely new impl mostly under CPointerManager Also adds beginSimple to OpenGL for simple render passes (e.g. cursor)
Ring and strip are not implemented. Will I implement this? God fucking knows. Nobody seems to have that anyways.
|
Thanks guys! |
|
Love how there has to be one last commit before the merge because that’s a beautiful way to get SEGVs all over the floor(always happens, you think something’s good to go “Ill just add this and we can ship it” - Famous last words) |
|
there was no changes, I just reworded the commits |
|
Wait but ring and strips are implemented |
|
nope xD if someone has one and opens a bug report I might add it (I still dunno what they are) |
I mean- ring works for me? At least libinput suggests so(see screenshot above) |
|
libinput will see it but the apps don't get these events forwarded |
I see. Well, do I have to open an issue to get the ring implemented? X) |
|
would be nice |
|
This moves wlr_cursor to a completely new impl mostly under CPointerManager
Still needs tablet support to be shipped.
TODO:
Allow(WLR_NO_HARDWARE_CURSORScursor:no_hardware_cursors. Dynamic as well.)New stuff:
cursor:no_hardware_cursorsreplaces the wlr envcursor:hotspot_paddingdefault1, the amount of padding around the hotspot around monitor edges. Set to 10 to see what I mean.