Replace monitor rule when disabling head. Closes #5978 #6136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
May 18, 2024
|
As mentioned in the issue thread, it looks like with this I can disable monitor via kanshi, but cannot re-enable it. Probably because of a similar problem. I'll try to fix that too UPDATE: looks like it's working after last commit. I'll wait for people to confirm this in the issue thread before re-requesting review |
|
tag me when ready and tested |
|
@vaxerski this is ready to be reviewed |
vaxerski
reviewed
May 23, 2024
Yes, a few people reported back and it looks like we can close the issue |
The-Briel-Deal
pushed a commit
to The-Briel-Deal/Hyprland
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes Issue #5978. The main reason was that the monitor rule was not updated, and thus the head would get re-enabled when calling
performMonitorReloadIs there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I'm not sure this is the best way of doing it. Would it be a better idea to make
Monitor.activeMonitorRulea pointer to the actual rule?Is it ready for merging, or does it need work?
See above.