systemd,dbus: import PATH XDG_DATA_DIRS variables into systemd and dbus session #6640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRTitor
changed the title
13 tasks
JohnRTitor
added a commit
to JohnRTitor/nixpkgs
that referenced
this pull request
Jun 26, 2024
Importing PATH into the systemd environment is done by default in Hyprland v0.41.2+ (hyprwm/Hyprland#6640) We soft deprecate this option here for versions >= 0.41.2.
JohnRTitor
added a commit
to JohnRTitor/nixpkgs
that referenced
this pull request
Jun 26, 2024
Importing PATH into the systemd environment is done by default in Hyprland v0.41.2+ (hyprwm/Hyprland#6640) We soft deprecate this option here for versions >= 0.41.2.
10 tasks
JohnRTitor
added a commit
to JohnRTitor/nixpkgs
that referenced
this pull request
Jun 26, 2024
Importing PATH into the systemd environment is done by default in Hyprland v0.41.2+ (hyprwm/Hyprland#6640) We soft deprecate this option here for versions >= 0.41.2.
JohnRTitor
added a commit
to JohnRTitor/nixpkgs
that referenced
this pull request
Jun 26, 2024
Importing PATH into the systemd environment is done by default in Hyprland v0.41.2+ (hyprwm/Hyprland#6640) We soft deprecate this option here for versions >= 0.41.2.
JohnRTitor
added a commit
to JohnRTitor/nixpkgs
that referenced
this pull request
Jun 26, 2024
Importing PATH into the systemd environment is done by default in Hyprland v0.41.2+ (hyprwm/Hyprland#6640) We soft deprecate this option here for versions >= 0.41.2.
JohnRTitor
added a commit
to JohnRTitor/nixpkgs
that referenced
this pull request
Jun 26, 2024
Importing PATH into the systemd environment is done by default in Hyprland v0.41.2+ (hyprwm/Hyprland#6640) We soft deprecate this option here for versions >= 0.41.2.
JohnRTitor
added a commit
to JohnRTitor/nixpkgs
that referenced
this pull request
Jun 26, 2024
Importing PATH into the systemd environment is done by default in Hyprland v0.41.2+ (hyprwm/Hyprland#6640) We soft deprecate this option here for versions >= 0.41.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
When opening links from a browser that would otherwise open in another app present in the system, it fails to find the app. This is because PATH is not imported into systemd/dbus.
We are currently using a workaround in NixOS to explicitly define the systemd environment PATH, but ideally it should be set by the Window manager/DE at login.
An open issue highlighted this for the past one year #2800 and several threads (ie. on discourse) on the internet have popped up asking the user to manually import PATH. Lets not hold this any longer and let this issue die in peace.
In addition to
PATH,XDG_DATA_DIRSshould be imported as well, due to it containing useful things like desktop files.This issue affects flatpak apps as well.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This is backwards compatible.
Is it ready for merging, or does it need work?
Ready. I am using the patch on NixOS and it works.