Add "highest" mode to Monitor for autoconfiguration. #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Adds 2 new monitor resolution modes.
-- highrr -> highest with refreshrate preference
-- highres -> highest with resolution preference
Should none be possible for whatever reason, then it will default to preferred.
These 2 features are useful to autoconfigure monitors that do not have a good preferred mode. aka 4k monitor defaulting to 1080p or high refreshrate defaulting to 60.
This also means that switching between them is now possible.
this would add a rule for all random monitors to use their "best" possible setting.
monitor=,highrr,auto,1
OR
monitor=,highres,auto,1
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
If someone has wonky setups that can be tested with this, then please do so, it was intended for exactly this.
Is it ready for merging, or does it need work?
Compiles and works as intended on the monitors I was able to test.
Review needed obviously, otherwise ready imo.