fix crash #715
Merged
fix crash #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes #711
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I'm pretty shure this is not how you would do it!
there is a problem in toggleWindowGroup if that group is in fullscreen mode.
I think the pPrevious- and pNextGroupMember of the first window are set to nullptr, after that
the nextGroupMember calls getGroupMemberCount, but with a Pointer to a group member that
has it's next prev pointers nulled, getGroupMemberCount will crash.
Since it is a crashing bug, if you don't have time to fix it yourself, use this first?
Is it ready for merging, or does it need work?
I think yes.
It's not a big change, look at it, what could possibly go wrong!?