Improve several hyprctl commands #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fufexan
approved these changes
Oct 25, 2022
|
I'm all in for this PR, but why those commands in those particular? |
|
Mostly because they were ones that took additional arguments, and gave somewhat unclear |
vaxerski
reviewed
Oct 25, 2022
vaxerski
reviewed
Oct 25, 2022
|
can you plox squash |
Added better help for some hyprctl commands. Failed commands should now 'fail' by returning a nonzero status to the shell Fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This adds better help for some hyprctl subcommands, particularly
dispatch,keyword,hyprpaperandsetcursor. It also makes them return a nonzero exit status to the shellwhen they do not have enough arguments.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No, not that I am aware of.
Is it ready for merging, or does it need work?
Works for me (tm), but yes, it should be ready to merge.