Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No xwayland overhaul #920

Merged
merged 7 commits into from Oct 27, 2022
Merged

No xwayland overhaul #920

merged 7 commits into from Oct 27, 2022

Conversation

vaxerski
Copy link
Member

@vaxerski vaxerski commented Oct 26, 2022

Changes how NO_XWAYLAND is handled.

+new ci for no xwayland

Fixes #178

@vaxerski vaxerski requested a review from fufexan October 26, 2022 20:39
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but lgtm.

@vaxerski
Copy link
Member Author

@fufexan thats what I fucking tagged you for

@vaxerski
Copy link
Member Author

what is to check is mostly whether it will compile without any xorg libraries installed.

@rakino
Copy link
Contributor

rakino commented Oct 27, 2022

@vaxerski I can confirm it builds and runs without direct references to X.

hyprland dot

@vaxerski
Copy link
Member Author

thank you. :)

@vaxerski vaxerski merged commit d5a0610 into main Oct 27, 2022
@rakino
Copy link
Contributor

rakino commented Oct 27, 2022

Sorry to disturb, there's one more thing...

I'm using libglvnd for GL dispatching, and it won't install gl.pc when building without X.

Substituting dependency('GL') with dependency('opengl') in Hyprland's src/meson.build solves the problem.

image

@vaxerski
Copy link
Member Author

please tag @fufexan for meson stuff. I would also like to remind you that the numero uno official way to compile is always CMake. Meson is not maintained by me

@fufexan
Copy link
Member

fufexan commented Oct 27, 2022

Feel free to make a PR, but I can only review it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link errors when building without xwayland
4 participants