Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error checking while changing wallpaper. #141

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Fix error checking while changing wallpaper. #141

merged 1 commit into from
Feb 25, 2024

Conversation

stephentoth
Copy link
Contributor

@stephentoth stephentoth commented Feb 25, 2024

In response to #138
Fixes being able to assign a wallpaper to a nonexistent monitor by throwing an error if the monitor doesn't exist.
Clarified README to the specifics of the handleWallpaper function.

Without really modifying the existing logic for the if (MONITOR.empty()) { part there isn't a neat way of just assigning a wallpaper to all screens at once.

This does fix the issue aswell as follows:

$ hyprctl hyprpaper listactive
eDP-1 = <wp1>
HDMI-A-1 = <wp2>

 $ hyprctl hyprpaper preload <wp3>
ok

$ hyprctl hyprpaper wallpaper ", <wp3>"
ok
$ hyprctl hyprpaper listactive
eDP-1 = <wp1>
HDMI-A-1 = <wp2>

$ hyprctl hyprpaper wallpaper "ramd, <wp3>"
wallpaper failed (no such monitor)
$ hyprctl hyprpaper listactive
eDP-1 = <wp1>
HDMI-A-1 = <wp2>

clarified README to specifics of the handleWallpaper function
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oke

@vaxerski vaxerski merged commit dfd3d09 into hyprwm:main Feb 25, 2024
1 check passed
vaxerski pushed a commit that referenced this pull request Jul 17, 2024
…141)

clarified README to specifics of the handleWallpaper function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants