screencopy: safer iteration of vector in destroyStream

hyprwm · Nov 20, 2023 · 11009ba · 11009ba
1 parent 716da5e
commit 11009ba
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/portals/Screencopy.cpp b/src/portals/Screencopy.cpp
@@ -1009,7 +1009,13 @@ void CPipewireConnection::destroyStream(CScreencopyPortal::SSession* pSession) {
         return;
 
     if (!PSTREAM->buffers.empty()) {
+        std::vector<SBuffer*> bufs;
+
         for (auto& b : PSTREAM->buffers) {
+            bufs.push_back(b.get());
+        }
+
+        for (auto& b : bufs) {
             pwStreamRemoveBuffer(PSTREAM, b->pwBuffer);
         }
     }