Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added back screenshot functionality #127

Merged
merged 11 commits into from Nov 5, 2023

Conversation

eneoli
Copy link
Contributor

@eneoli eneoli commented Nov 4, 2023

Added back the screenshot functionality by using grim and slurp under the hood.

includes all functions from org.freedesktop.impl.portal.Screenshot (Screenshot, PickColor)

Fixes: #124

src/portals/Screenshot.cpp Outdated Show resolved Hide resolved
src/portals/Screenshot.cpp Show resolved Hide resolved
src/portals/Screenshot.cpp Outdated Show resolved Hide resolved
src/helpers/MiscFunctions.cpp Outdated Show resolved Hide resolved
@eneoli eneoli requested a review from vaxerski November 4, 2023 22:22
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest looks alright. Sorry for a late review, idfk github's notifications arent fucking showing up I hate this platform

src/portals/Screenshot.cpp Outdated Show resolved Hide resolved
src/portals/Screenshot.cpp Outdated Show resolved Hide resolved
src/portals/Screenshot.cpp Outdated Show resolved Hide resolved
src/helpers/MiscFunctions.cpp Outdated Show resolved Hide resolved
src/helpers/MiscFunctions.cpp Outdated Show resolved Hide resolved
src/helpers/MiscFunctions.cpp Outdated Show resolved Hide resolved
@eneoli
Copy link
Contributor Author

eneoli commented Nov 5, 2023

That's it I guess. This should resolve #124, no?

@eneoli eneoli requested a review from vaxerski November 5, 2023 00:42
@vaxerski
Copy link
Member

vaxerski commented Nov 5, 2023

mhm, add a Fixes: #124 to your MR description and github will close it on merge

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks :)

@eneoli
Copy link
Contributor Author

eneoli commented Nov 5, 2023

Thanks for building Hyprland ^^

@vaxerski vaxerski merged commit b2fc111 into hyprwm:master Nov 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshot functionality removed?
2 participants