Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add double quote escaping #96

Merged
merged 3 commits into from
Sep 16, 2023
Merged

feat: add double quote escaping #96

merged 3 commits into from
Sep 16, 2023

Conversation

commrade-goad
Copy link
Contributor

This pr will add an escape char for double quote in the window title string

  • issue
[LOG] [screencopy] SelectSources:
[LOG] [screencopy]  | /org/freedesktop/portal/desktop/request/1_56507/obs2
[LOG] [screencopy]  | /org/freedesktop/portal/desktop/session/1_56507/obs1
[LOG] [screencopy]  | appid:
[LOG] [screencopy] option cursor_mode to 2
[LOG] [screencopy] option persist_mode to 2
[LOG] [screencopy] unused option multiple
[LOG] [screencopy] unused option types
[LOG] [screencopy] restore data invalid / missing, prompting
[LOG] execAndGet: WAYLAND_DISPLAY=wayland-1 QT_QPA_PLATFORM="wayland" XCURSOR_SIZE=24 HYPRLAND_INSTANCE_SIGNATURE=d126d2c09204a09b0b10ce4f999520fc901fbf0a_1694861673 XDPH_WINDOW_SHARING_LIST="3451312672[HC>]Alacritty[HT>]./build/xdg-desktop-portal-hyprland[HE>]3451313024[HC>]discord[HT>]"testing pr  | NUCLEAR POWER PLANT - Discord[HE>]3451313424[HC>]Alacritty[HT>]goad@arch-btw:~/git/testing/xdg-desktop-portal-hyprland[HE>]3451313776[HC>]brave-browser[HT>]Comparing hyprwm:master...commrade-goad:quote-escape · hyprwm/xdg-desktop-portal-hyprland - Brave[HE>]" hyprland-share-picker 2>&1
sh: -c: line 1: unexpected EOF while looking for matching `"'
sh: -c: line 2: syntax error: unexpected end of file
[LOG] [screencopy] SHAREDATA returned selection -1

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the entire damn point of sanitizeNameForWindowList and you just ignored it.

@commrade-goad
Copy link
Contributor Author

alright sorry. i moved it to the sanitizeNameForWindowList function now.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slap it with a clang-format and it should be alr.

@commrade-goad
Copy link
Contributor Author

alright done

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@vaxerski vaxerski merged commit b645ab7 into hyprwm:master Sep 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants