-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare subquery pruning #2560
Prepare subquery pruning #2560
Conversation
std::set<ChunkID> compute_chunk_exclude_list(const PredicatePruningChain& predicate_pruning_chain,
const std::shared_ptr<StoredTableNode>& stored_table_node); in Same goes for std::shared_ptr<AbstractOperator> _translate_node_recursively(const std::shared_ptr<AbstractLQPNode>& node) const; in This is a cherry-pick of the new LoCs. Großes Indianerehrenwort 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo and one tiny issue remaining (comment). Apart from that, all good.
Second time ASAN issues. I thought it's a glitch in the CI, but it might be an actual issue. |
Just ran the failing stage again on one of our servers (no problems there), might try it on the CI machine later. Edit: Ran it on the CI server, no issue. Restarted the CI pipeline. |
I'm really giving it up now. CI failed on another sanitizer test case that did not fail anywhere else (but seems reasonable and is fixed). At least the sanitizer tests should work now. |
This PR prepares the codebase for subquery pruning.
This PR prepares the codebase for subquery pruning.
This PR prepares the codebase for subquery pruning. I.e., the chunk pruning code is moved to an own file. Also, we introduce a check that ensures acyclic operator task graphs. All in all, these changes are to be merged previously so we can focus on the actual dynamic subquery pruning when we open a dedicated PR for it. Besides, the usual Monk (style, fixing comments, auto to stick, const, superfluous includes, ...).