Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DYOD] Team 1 - Sprint 4 #2575

Merged
merged 9 commits into from
Jul 1, 2023
Merged

[DYOD] Team 1 - Sprint 4 #2575

merged 9 commits into from
Jul 1, 2023

Conversation

niklasmohrin
Copy link
Contributor

No description provided.

@niklasmohrin niklasmohrin added the FullCI Run all CI tests (slow, but required for merge) label Jun 13, 2023
@niklasmohrin niklasmohrin marked this pull request as ready for review June 13, 2023 19:43
@niklasmohrin
Copy link
Contributor Author

@dey4ss Do you have an idea why the full CI is failing? We only modified the test binaries, so hyriseConsole should behave just like before, right? Should we just trigger a re-run?

@dey4ss
Copy link
Member

dey4ss commented Jun 14, 2023

We've recently been encountering flaky behavior of said test stage and are investigating the root cause. I restarted the CI pipeline.

dey4ss
dey4ss reviewed Jun 15, 2023
View reviewed changes
src/test/lib/logical_query_plan/alias_node_test.cpp Outdated Show resolved Hide resolved
src/test/lib/logical_query_plan/alias_node_test.cpp Outdated Show resolved Hide resolved
src/test/lib/logical_query_plan/alias_node_test.cpp Outdated Show resolved Hide resolved
src/test/lib/logical_query_plan/except_node_test.cpp Outdated Show resolved Hide resolved
src/test/lib/logical_query_plan/except_node_test.cpp Outdated Show resolved Hide resolved
src/test/lib/logical_query_plan/except_node_test.cpp Outdated Show resolved Hide resolved
src/test/lib/operators/limit_test.cpp Outdated Show resolved Hide resolved
src/test/lib/operators/limit_test.cpp Outdated Show resolved Hide resolved
src/test/lib/operators/aggregate_test.cpp Show resolved Hide resolved
src/test/lib/logical_query_plan/alias_node_test.cpp Show resolved Hide resolved
@dey4ss
Copy link
Member

dey4ss commented Jun 15, 2023

Nothing deal-braking, just some minor comments

@niklasmohrin niklasmohrin requested a review from dey4ss June 27, 2023 09:20
dey4ss
dey4ss approved these changes Jun 30, 2023
View reviewed changes
src/test/lib/logical_query_plan/except_node_test.cpp Outdated Show resolved Hide resolved
src/test/lib/operators/limit_test.cpp Outdated Show resolved Hide resolved
@Bouncner Bouncner enabled auto-merge (squash) June 30, 2023 09:18
@Bouncner Bouncner merged commit 23441ae into hyrise:master Jul 1, 2023
3 of 4 checks passed
nikriek pushed a commit that referenced this pull request Oct 28, 2023
@niklasmohrin @Finn-HPI
@dey4ss @nikriek
[DYOD] Team 1 - Sprint 4 (#2575)
328c115 
Add tests for LQP nodes and operators.

Co-authored-by: Finn Schoellkopf <schoellkopf.finn@gmail.com>
Co-authored-by: Daniel Lindner <27929897+dey4ss@users.noreply.github.com>
nikriek pushed a commit that referenced this pull request Nov 6, 2023
@niklasmohrin @Finn-HPI
@dey4ss @nikriek
[DYOD] Team 1 - Sprint 4 (#2575)
cd3dbe5 
Add tests for LQP nodes and operators.

Co-authored-by: Finn Schoellkopf <schoellkopf.finn@gmail.com>
Co-authored-by: Daniel Lindner <27929897+dey4ss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dey4ss dey4ss dey4ss approved these changes

@Finn-HPI Finn-HPI Finn-HPI left review comments

@Bouncner Bouncner Bouncner approved these changes

Assignees
No one assigned
Labels
FullCI Run all CI tests (slow, but required for merge)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@niklasmohrin @dey4ss @Bouncner @Finn-HPI