Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive Scheduler Test and Scheduler Shutdown Fix #2580

Merged
merged 14 commits into from
Jun 22, 2023
Merged

Recursive Scheduler Test and Scheduler Shutdown Fix #2580

merged 14 commits into from
Jun 22, 2023

Conversation

Bouncner
Copy link
Collaborator

@Bouncner Bouncner commented Jun 15, 2023 •
edited
Loading

Planned work on Hyrise might recursively add tasks to the scheduler. This PR adds a test doing exactly that (a simple merge sort).

This test triggered a minor issue when shutting down the scheduler. This issue should be fixed with the PR.

Minor:

  • changes to Jenkins are solely to avoid starting multiple Hyrise instances using all the threads of the system (the tests are using small scale factors, but we still spawns (partially spinning) worker threads on each core).
  • changes in the benchmarklib are solely minor stuff as auto-to-stick

@Bouncner Bouncner added the FullCI Run all CI tests (slow, but required for merge) label Jun 15, 2023
@Bouncner Bouncner requested a review from dey4ss June 19, 2023 11:16
@Bouncner Bouncner merged commit 8114ddd into master Jun 22, 2023
4 checks passed
@Bouncner Bouncner deleted the martin/merge_sort branch June 22, 2023 18:32
@Bouncner Bouncner mentioned this pull request Jun 26, 2023
Merged
nikriek pushed a commit that referenced this pull request Oct 28, 2023
@Bouncner @nikriek
Recursive Scheduler Test and Scheduler Shutdown Fix (#2580)
a240f18 
Adding a test that recursively adds tasks to the scheduler (a simple merge sort).

This test triggered a minor issue when shutting down the scheduler. This
issue should be fixed with the PR.
nikriek pushed a commit that referenced this pull request Nov 6, 2023
@Bouncner @nikriek
Recursive Scheduler Test and Scheduler Shutdown Fix (#2580)
29b3a3d 
Adding a test that recursively adds tasks to the scheduler (a simple merge sort).

This test triggered a minor issue when shutting down the scheduler. This
issue should be fixed with the PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dey4ss dey4ss dey4ss approved these changes

Assignees
No one assigned
Labels
FullCI Run all CI tests (slow, but required for merge)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bouncner @dey4ss