Allow Apple Clang #2584
Merged
Allow Apple Clang #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😱 |
I am an Apple fanboy. ¯_(ツ)_/¯ Next step is getting rid of Linux. |
|
Requesting a review from you @dey4ss, even though the pipeline is not mergeable right now. When we agree on the PR, I will re-add the deleted stages. |
dey4ss
approved these changes
Jul 10, 2023
nikriek
pushed a commit
that referenced
this pull request
Oct 28, 2023
Enables Apple's clang version as it has sufficiently caught up with LLVM.
nikriek
pushed a commit
that referenced
this pull request
Nov 6, 2023
Enables Apple's clang version as it has sufficiently caught up with LLVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Apple's clang version as it has sufficiently caught up with LLVM. An additional LLVM installation on MacOS is quite large. If our students don't need it, we shouldn't require it. Benchmarking won't be done on macOS machines anyways.
Changes: