Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to ignore check certificate #41

Closed
HalfEatenPie opened this issue Dec 2, 2021 · 3 comments
Closed

Ability to ignore check certificate #41

HalfEatenPie opened this issue Dec 2, 2021 · 3 comments

Comments

@HalfEatenPie
Copy link

HalfEatenPie commented Dec 2, 2021

Is your feature request related to a problem? Please describe.
get_by* functions are pulling from a remote server that uses SSL for encryption. These servers can sometimes have an expired SSL certificate which ends up failing the entire function. While SSL encryption is important, sometimes it's a barrier to access the dataset during time crunches.

Describe the solution you'd like
An option (by default disabled, but an option nevertheless) to ignore checking the certificate would be appreciated. (e.g. wget --no-check-certificate). The function seems to be using https://github.com/cheginit/async_retriever, so further modifications may be needed to pass-through these changes.

Describe alternatives you've considered
Downloading the full dataset locally on our computing cluster then working on it locally. This increases our computing operations cost, storage costs, and time cost (as we create a local copy of the dataset).

Thank you very much for creating this package and being so helpful. This is a feature request.

cheginit pushed a commit to hyriver/async-retriever that referenced this issue Dec 2, 2021
cheginit pushed a commit that referenced this issue Dec 2, 2021
@cheginit
Copy link
Collaborator

cheginit commented Dec 2, 2021

Your feature request makes sense. I exposed the ssl argument of aiohttp. Until I release new official versions, you can install both async_retriever and pydaymet from their respective repositories like so:

pip install git+https://github.com/cheginit/pydaymet
pip install git+https://github.com/cheginit/async_retriever

Then you can pass ssl=False to get_by* functions or --disable_ssl to PyDaymet's CLI to disable the check.

@HalfEatenPie
Copy link
Author

Thanks for the quick turnaround! Your resolution works perfectly and looking forward to this feature being included in the next release.

@cheginit
Copy link
Collaborator

cheginit commented Dec 2, 2021

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants