-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster changebasis
#308
Merged
Merged
Faster changebasis
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 98.46% 98.41% -0.06%
==========================================
Files 13 12 -1
Lines 1241 1263 +22
==========================================
+ Hits 1222 1243 +21
- Misses 19 20 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Now the performance is much better: julia> using BasicBSpline, BenchmarkTools
julia> P1 = BSplineSpace{1}(KnotVector([1, 3, 5, 8]))
BSplineSpace{1, Int64, KnotVector{Int64}}(KnotVector([1, 3, 5, 8]))
julia> P2 = BSplineSpace{1}(KnotVector([1, 3, 5, 6, 8, 9]))
BSplineSpace{1, Int64, KnotVector{Int64}}(KnotVector([1, 3, 5, 6, 8, 9]))
julia> @benchmark changebasis(P1, P2)
BenchmarkTools.Trial: 10000 samples with 173 evaluations.
Range (min … max): 616.832 ns … 23.942 μs ┊ GC (min … max): 0.00% … 96.58%
Time (median): 651.231 ns ┊ GC (median): 0.00%
Time (mean ± σ): 778.790 ns ± 1.384 μs ┊ GC (mean ± σ): 12.35% ± 6.72%
▅██▇▅▄▃▃▂▁▁▂▃▃▂▁ ▂
█████████████████████████▇██▇▇▆▇▆▆▆▆▆▆▅▆▆▄▇▆▇▆▆▅▄▆▄▅▅▅▄▃▃▄▄▃ █
617 ns Histogram: log(frequency) by time 1.18 μs <
Memory estimate: 1.28 KiB, allocs estimate: 14. |
hyrodium
force-pushed
the
feature/faster_changebasis
branch
from
March 8, 2023 16:46
7eb45a6
to
0d1df1c
Compare
hyrodium
force-pushed
the
feature/faster_changebasis
branch
from
March 8, 2023 17:10
537b9e7
to
aa47ad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR