This repository has been archived by the owner on Mar 17, 2022. It is now read-only.
Product type fix #56
Merged
Product type fix #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note/ToDo: _translation_porduct_type has a typo that was deliberately not corrected. Correcting it was result in brake product synchronization for products already translated in the BD.
To correct this we could enhance the new class method addProductTypeMeta() with a switch/case implementation
case "typo: replaces with correct meta name and use existing value
case "not found": add meta
case "found": do nothing
Let me know if you want me to implement this?