Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python2 compatibility #100

Closed
larsrinn opened this issue Dec 9, 2019 · 4 comments · Fixed by #105
Closed

Drop Python2 compatibility #100

larsrinn opened this issue Dec 9, 2019 · 4 comments · Fixed by #105

Comments

@larsrinn
Copy link

larsrinn commented Dec 9, 2019

Django dropped Python2 support a while ago already. In Django 3.0 python_2_unicode_compatibility and django.utils.six have been deleted. Hence starting an application that uses django-enumfields fails.
@brianwawok
Copy link

Indeed. Very easy to make the fix.

I would be happy to put together a 1.0 release that only supports python3 (I have it done locally). Current users could feel free to use the 0.9 release. If I were to make a PR like this, would @talebbits or someone else be willing to merge me and push to pypi?

@johnthagen
Copy link
Contributor

See #96, a fork may be needed to keep this project alive. 😕

@matthewwithanm
Copy link
Contributor

@lettertwo @talebbits How about adding another maintainer?

@johnthagen
Copy link
Contributor

Could also remove enum34 usage when dropping Python 2.7:

django-enumfields/setup.py

Line 65 in 70a2f2c

":python_version<'3.4'": ['enum34'],

akx added a commit to akx/django-enumfields2 that referenced this issue Jan 16, 2020
@akx
Drop Python 2.7 support
8ddfd64 
Refs hzdg#100
@akx akx mentioned this issue Jan 16, 2020
Merged
@akx akx closed this as completed in #105 Jan 16, 2020
akx added a commit that referenced this issue Jan 16, 2020
@akx
Drop Python 2.7 support
3a9f92d 
Refs #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version compatibility changes akx/django-enumfields2
4 participants
@matthewwithanm @brianwawok @johnthagen @larsrinn