Add IntEnum (like the standard library's IntEnum) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,4 +26,5 @@ def test_bound_form_with_instance(): | |||
|
|
|||
| def test_choices(): | |||
| form = get_form() | |||
| assert form.base_fields["zero2"].choices == [(0, 'ZERO'), (1, 'ONE')] | |||
| assert form.base_fields["zero2"].choices == [(0, 'Zero'), (1, 'One')] | |||
| assert form.base_fields["int_enum"].choices == BLANK_CHOICE_DASH + [(0, 'foo'), (1, 'B')] | |||
There was a problem hiding this comment.
So, is this backward incompatible change, since the code for zero2 stays the same but still the choices change?
There was a problem hiding this comment.
No – the code for zero2 actually does change, albeit in a subtle way :)
IntEnum used to be imported directly from the stdlib.
However, now we're using our fancier IntEnum, which as the same choices behavior as enumfields.Enum, i.e. auto-titling the name for a choice label when no explicit label exists.
Before:
from enum import Enum, IntEnumAfter:
from enumfields import Enum, IntEnum, EnumField, EnumIntegerFieldThere was a problem hiding this comment.
Ah, right. I didn't notice that this import change was actually in tests/models.py. Yep. This is all good then.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.