Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M181 - docs #67

Merged
merged 1 commit into from Apr 23, 2023
Merged

M181 - docs #67

merged 1 commit into from Apr 23, 2023

Conversation

lromor
Copy link
Contributor

@lromor lromor commented Apr 23, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ed37f63) 47.66% compared to head (3bc3766) 47.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   47.66%   47.66%           
=======================================
  Files          37       37           
  Lines        4284     4284           
=======================================
  Hits         2042     2042           
  Misses       2242     2242           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lromor lromor force-pushed the m181-docs branch 2 times, most recently from 28f6bac to 1eb30cc Compare April 23, 2023 18:03
G-code.md Outdated
@@ -159,6 +159,7 @@ M117 | Display message.
M119 | Get endstop status.
M120 | Enable pause switch detection.
M121 | Disable pause switch detection.
M181 Snn | Set planning buffer size to nn. Requires the machine to stop.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Requires the machine to stop' sounds like that is a requirement that the user needs to fulfill.
'Will flush the current queue first' would probably better explain what is happening.

Also, add a description that without parameter, it sets it to the default size.

@hzeller hzeller merged commit b1469b2 into hzeller:main Apr 23, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants