Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samplebase.py does not accept '--led-gpio-mapping=regular-pi1' #1266

Closed
beta-tester opened this issue Mar 5, 2021 · 1 comment
Closed

samplebase.py does not accept '--led-gpio-mapping=regular-pi1' #1266

beta-tester opened this issue Mar 5, 2021 · 1 comment

Comments

@beta-tester
Copy link
Contributor

beta-tester commented Mar 5, 2021

hi,

i just dug up my old Raspberry Pi 1B rev.1 and let it drive my also old led-matrix panels.
first i stubled around with the RPi 1B rev1 related issue of the missing green color at the top half of the matrix.

after i found the solution to that issue by using --led-gpio-mapping=regular-pi1, i now observed another issue.

rpi-rgb-led-matrix/bindings/python/samples/samplebase.py does not accept that option.

error: argument -m/--led-gpio-mapping: invalid choice: 'regular-pi1' (choose from 'regular', 'adafruit-hat', 'adafruit-hat-pwm')

i can add that option to the list of accepted choices in samplebase.py but i guess that there are other options/choices missing for other parameters. maybe this file is not up to date.

@hzeller
Copy link
Owner

hzeller commented Mar 5, 2021

Yes, I think old Pi's are so rare and using Python on a Pi1 is very slow to use that nobody encountered this omission yet.
Please send a pull request with that choice added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants