Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-generated cython files. #1679

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

hzeller
Copy link
Owner

@hzeller hzeller commented Jul 10, 2024

They easily get stale, and it is better to re-generate at compile time.

@hzeller hzeller force-pushed the feature-20240709-remove-pregenerated-cython branch from cd88523 to c331dac Compare July 10, 2024 05:41
@hzeller
Copy link
Owner Author

hzeller commented Jul 10, 2024

CC @neuschaefer to review.

@hzeller hzeller mentioned this pull request Jul 10, 2024
@neuschaefer
Copy link
Contributor

Probably also a good idea:

diff --git a/shell.nix b/shell.nix
index 94d8a86..d19591e 100644
--- a/shell.nix
+++ b/shell.nix
@@ -11,5 +11,6 @@ pkgs.mkShell {
       ffmpeg
       pkg-config
       python3
+      python3Packages.cython
     ];
 }

They easily get stale, and it is better to re-generate at compile
time.

Also: switch to Python3 by default.
@hzeller hzeller force-pushed the feature-20240709-remove-pregenerated-cython branch from c331dac to fd969bc Compare July 11, 2024 01:12
@hzeller
Copy link
Owner Author

hzeller commented Jul 11, 2024

Probably also a good idea: (add stuff to shell.nix)

Thanks. Also had to add distutils-extra; it looks like the distutils stuff is deprecated and removed in 3.12, but I don't know enough about Python to fix that. Up for refinement :)

@hzeller hzeller merged commit 0e8ca69 into master Jul 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants