Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2S_New Right_ S2S_Process [1] #10084

Closed
2 tasks done
SahaLinaPrueger opened this issue Aug 9, 2022 · 20 comments · Fixed by #10219, #10466, #10546 or #10574
Closed
2 tasks done

S2S_New Right_ S2S_Process [1] #10084

SahaLinaPrueger opened this issue Aug 9, 2022 · 20 comments · Fixed by #10219, #10466, #10546 or #10574
Assignees
Labels
backend Affects the web backend feature A new feature to be developed (ticket type) qa-verified Issue has been tested and verified by QA s2s Issues related to the SORMAS2SORMAS functionality vaadin-app Affects the Vaadin application

Comments

@SahaLinaPrueger
Copy link

SahaLinaPrueger commented Aug 9, 2022

Feature Description

A new user right is introduced for S2S because of data protection reasons.

Proposed Change

  • Implementation of right SORMAS_TO_SORMAS_Process

  • Name of right:
    S2S_Process

  • Description of right:
    Only users with this right are allowed to process received shares and only this user is allowed to see & use the share directory.

  • The right is linked to the following roles:
    none

  • Change right SORMAS_TO_SORMAS_SHARE

  • Name of right:
    S2S_Share

  • Description of right:

  • Users with this right can initiate a share for a case/contact (is already included in the right).
  • The rights from S2S_Process must be withdrawn from the right SORMAS_TO_SORMAS_SHARE
    (so a user with the right SORMAS_TO_SORMAS_SHARE can not see the share directory and can not process incoming share request.)
  • The right is linked to the following roles:
    none

Acceptance Criteria

Implementation Details

Additional Information

@SahaLinaPrueger SahaLinaPrueger added feature A new feature to be developed (ticket type) s2s Issues related to the SORMAS2SORMAS functionality labels Aug 9, 2022
@SahaLinaPrueger
Copy link
Author

@JaquM-HZI

@markusmann-vg markusmann-vg changed the title S2S_New Right_ S2S_Process S2S_New Right_ S2S_Process [1] Aug 10, 2022
@leventegal-she
Copy link
Contributor

  • The right is linked to the following roles:
    none

@SahaLinaPrueger does the above mean that no default user role will have right to share and/or process share requests?
Do we need to remove the SORMAS_TO_SORMAS_SHARE right of currently existing user roles?

@SahaLinaPrueger
Copy link
Author

Yes, that is exactly what is meant.

@ChristopherRiedel
Copy link
Contributor

Yes, that is exactly what is meant.

@SahaLinaPrueger Just to be sure: This then means that on all instances (development, test and production) there will be no more users that can use Sormas2Sormas until someone manually reassigns these rights in user role management. Is this desired? I would actually have expected that the rights would only be removed from DefaultUserRoles, but all users would be able to do everything as before.

@ChristopherRiedel ChristopherRiedel added the needs-response Response from the issue creator required label Aug 31, 2022
@SahaLinaPrueger
Copy link
Author

SahaLinaPrueger commented Aug 31, 2022

@ChristopherRiedel thank you very much for the demand!
If it is possible to only remove the rights from the DefaultUserRoles AND already existing users are able to do everything as before this would be nice.

So when a new health department gets S2S, first of all no user should be able to operate S2S with the DefaultUserRoles.
If it is possible, that in health departments that already have S2S (and development and test instances), the users that already have S2S rights keep them, so SORMAS_TO_SORMAS_SHARE and SORMAS_TO_SORMAS_Process (and other rights that are needed for S2S) get automatically, that would be great. (@Jan-Boehme FYI)

@ChristopherRiedel
Copy link
Contributor

@SahaLinaPrueger Yes that's possible. I will make sure it is implemented that way.

@ChristopherRiedel ChristopherRiedel removed the needs-response Response from the issue creator required label Aug 31, 2022
leventegal-she pushed a commit that referenced this issue Aug 31, 2022
@AndyBakcsy-she AndyBakcsy-she added the qa-verified Issue has been tested and verified by QA label Sep 2, 2022
@AndyBakcsy-she
Copy link

Validated ticket on the latest version of sormas 1.75.0 deployed on test-de2 environment

@StefanKock StefanKock added backend Affects the web backend vaadin-app Affects the Vaadin application labels Sep 19, 2022
@leventegal-she
Copy link
Contributor

The user with S2S_Process right does not have With Ownership/View only filters.

With Ownership/View filters should be visible for all users regardless of user rights, it should only depend on the feature configuration

@leventegal-she leventegal-she reopened this Oct 7, 2022
leventegal-she pushed a commit that referenced this issue Oct 7, 2022
…on feature configuration and not based on rights
ChristopherRiedel pushed a commit that referenced this issue Oct 7, 2022
…on feature configuration and not based on rights (#10574)

Co-authored-by: Levente Gal <levente.gal.ext@vitagroup.ag>
@SahaLinaPrueger
Copy link
Author

The user with S2S_Process right does not have With Ownership/View only filters.
With Ownership/View filters should be visible for all users regardless of user rights, it should only depend on the feature configuration

@leventegal-she Can you explain what do you mean by that?

@leventegal-she
Copy link
Contributor

@SahaLinaPrueger I meant the filter added with #9787 was not visible only for the users that had S2S_SHARE right. But it should be visible for any user as long as s2s is configured on the system similarly to the share box like you commented here: #10084 (comment)

@abrudanancuta abrudanancuta removed the qa-verified Issue has been tested and verified by QA label Oct 17, 2022
@dragosb-vg
Copy link

Validated on test-de3, Version: 1.77.0-SNAPSHOT (ba98b49)
Tested all 'S2S_Process' - 'S2S_Share' rights combination on test-de-3 (with pending/accepted/revoked share requests to & from test-de1)

@dragosb-vg dragosb-vg added the qa-verified Issue has been tested and verified by QA label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment