Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event report date editable [0.5] #4175

Closed
3 tasks done
MateStrysewske opened this issue Jan 29, 2021 · 6 comments · Fixed by #5284
Closed
3 tasks done

Make event report date editable [0.5] #4175

MateStrysewske opened this issue Jan 29, 2021 · 6 comments · Fixed by #5284
Assignees
Labels
android-app Affects the Android app backend Affects the web backend change A change of an existing feature (ticket type) events qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application

Comments

@MateStrysewske
Copy link
Contributor

MateStrysewske commented Jan 29, 2021

Feature Description

Events have both a report date as well as an event date. Unlike the event date, the report date is not editable.

Problem Description

Since the event date is not mandatory, we have to fall back to the report date when we want to filter events by date, e.g. for the dashboard. This is problematic for things like retrospective data.

Proposed Change

  • Make the event report date editable. It needs to be a mandatory field to make sure that it can't be empty.
  • Add a validate method to EventFacadeEjb that is called during saveEvent that ensures that the report date is not empty (similar process as for cases)
  • Add date validation:
    • Date of report <= Current date
    • Event start date <= Date of report

Possible Alternatives

Additional Information

@MateStrysewske MateStrysewske added android-app Affects the Android app events vaadin-app Affects the Vaadin application change A change of an existing feature (ticket type) labels Jan 29, 2021
@MateStrysewske MateStrysewske added this to the Sprint 100 - 1.56.0 milestone Jan 29, 2021
@MateStrysewske
Copy link
Contributor Author

This is a prerequisite for #3004.

@bernardsilenou
Copy link

At event creation, users has to provide the report date just as in case creation. @kwa20 @MateStrysewske

@StefanKock StefanKock removed this from the Sprint 100 - 1.57.0 milestone Feb 19, 2021
@StefanKock StefanKock added the backend Affects the web backend label Mar 3, 2021
@markusmann-vg markusmann-vg changed the title Make event report date editable Make event report date editable [0.5] Mar 3, 2021
@bernardsilenou
Copy link

@MateStrysewske Sine the specification is the summary, I added a point on date validation. Hope this is OK?

@MateStrysewske
Copy link
Contributor Author

@bernardsilenou Adjusted it a little. We can't force the event end date to be before the report date because that would prevent users from creating ongoing events that are scheduled to be over at a specific point in time (e.g. festivals).

@bernardsilenou
Copy link

@MateStrysewske You are right, that is why i added the condition that the multiday event ==t. Because if multiday event == f, then the date of event is mapped to the end date. if multiple day event ==f, then the end date is always NA

DavidBaldsiefen added a commit that referenced this issue May 14, 2021
alexcaruntu-vita pushed a commit that referenced this issue May 14, 2021
* #4175: Make event report date editable

* Make event reportdate in androidapp editable #4175

* Remove accidental change #4175

Co-authored-by: Christopher Riedel <42139870+ChristopherRiedelSymeda@users.noreply.github.com>
Co-authored-by: Seal33 <klausbart@gmx.net>
Co-authored-by: DavidB <david.baldsiefen@gmx.de>
@AndyBakcsy-she AndyBakcsy-she self-assigned this May 14, 2021
@AndyBakcsy-she AndyBakcsy-she added the qa-verified Issue has been tested and verified by QA label May 14, 2021
@AndyBakcsy-she
Copy link

Validated ticket on the latest version of Sormas 1.60.0-snapshot on local environment setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-app Affects the Android app backend Affects the web backend change A change of an existing feature (ticket type) events qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants